Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS #18540

Conversation

tedyyan
Copy link
Contributor

@tedyyan tedyyan commented Jan 14, 2025

*More detailed description of your change,
Changed the following KafkaApi handler

handleCreateAcls
handleDeleteAcls
In Kraft mode, all requests are forwarded to the controller, and all authorization does not work, so I deleted some tests.

The forwarding test was covered by

testRaftShouldAlwaysForwardCreateAcls
testRaftShouldAlwaysForwardDeleteAcls

reopened for #18454

@github-actions github-actions bot added triage PRs from the community core Kafka Broker small Small PRs labels Jan 14, 2025
@tedyyan tedyyan changed the title KAFKA-18399 Remove-ZooKeeper-from-KafkaApis 6 Tedd KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS Jan 14, 2025
@chia7712 chia7712 merged commit 5b8319e into apache:trunk Jan 15, 2025
7 of 9 checks passed
@chia7712
Copy link
Member

the failed tests pass on my local - merge it to trunk and 4.0

chia7712 pushed a commit that referenced this pull request Jan 15, 2025
@github-actions github-actions bot removed the triage PRs from the community label Jan 16, 2025
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved core Kafka Broker small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants