KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS #18540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
tedyyan
changed the title
chia7712
approved these changes
Jan 15, 2025
|
the failed tests pass on my local - merge it to trunk and 4.0 |
chia7712
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ELETE_ACLS (#18540) Reviewers: Chia-Ping Tsai <[email protected]>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…ELETE_ACLS (apache#18540) Reviewers: Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…ELETE_ACLS (apache#18540) Reviewers: Chia-Ping Tsai <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…ELETE_ACLS (apache#18540) Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*More detailed description of your change,
Changed the following KafkaApi handler
handleCreateAcls
handleDeleteAcls
In Kraft mode, all requests are forwarded to the controller, and all authorization does not work, so I deleted some tests.
The forwarding test was covered by
testRaftShouldAlwaysForwardCreateAcls
testRaftShouldAlwaysForwardDeleteAcls
reopened for #18454