KAFKA-18399 Remove ZooKeeper from KafkaApis (12/N): clean up ZKMetadataCache, KafkaController and raftSupport #18542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaiJuWu
changed the title
TaiJuWu
changed the title
TaiJuWu
changed the title
viktorsomogyi
requested changes
Jan 15, 2025
| val configs = describeConfigsResult.configs.asScala.filter(_.name == propName) | ||
| assertEquals(1, configs.length) | ||
| val describeConfigsResponseData = configs.head | ||
| assertEquals(propName, describeConfigsResponseData.name) | ||
| assertEquals(propValue, describeConfigsResponseData.value) | ||
| >>>>>>> trunk |
There was a problem hiding this comment.
I believe these shouldn't be here :)
There was a problem hiding this comment.
Yes, I am working on this at that time and it is already removed. 🙂
TaiJuWu
commented
Jan 15, 2025
|
In order unblock other tasks, file https://issues.apache.org/jira/browse/KAFKA-18540 as follow up. |
chia7712
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM
the following cleanup are traced by https://issues.apache.org/jira/browse/KAFKA-18540, https://issues.apache.org/jira/browse/KAFKA-18539 and https://issues.apache.org/jira/browse/KAFKA-18552
|
#18549 fix the fail test |
|
@chia7712 thanks for review! |
chia7712
pushed a commit
to chia7712/kafka
that referenced
this pull request
Jan 15, 2025
…taCache, KafkaController and raftSupport (apache#18542) Reviewers: Viktor Somogyi-Vass <[email protected]>, Chia-Ping Tsai <[email protected]>
ijuma
reviewed
Jan 16, 2025
3 tasks
ijuma
pushed a commit
that referenced
this pull request
Jan 19, 2025
This was removed during removal of zk code (#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
ijuma
pushed a commit
that referenced
this pull request
Jan 19, 2025
This was removed during removal of zk code (#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…taCache, KafkaController and raftSupport (apache#18542) Reviewers: Viktor Somogyi-Vass <[email protected]>, Chia-Ping Tsai <[email protected]>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
This was removed during removal of zk code (apache#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…taCache, KafkaController and raftSupport (apache#18542) Reviewers: Viktor Somogyi-Vass <[email protected]>, Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
This was removed during removal of zk code (apache#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…taCache, KafkaController and raftSupport (apache#18542) Reviewers: Viktor Somogyi-Vass <[email protected]>, Chia-Ping Tsai <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
This was removed during removal of zk code (apache#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
In order unblock other tasks, file https://issues.apache.org/jira/browse/KAFKA-18540 as follow up.
Committer Checklist (excluded from commit message)