Revert "KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors (#18050)" #18544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on fatal coordinator errors (apache#18050)" This reverts commit 70d6312.
|
Besides the screenshot in #18050, you can also see that the build was last green just before the relevant commit was merged: 
|
|
CI all passed. Merged. |
kirktrue
added
KIP-848
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…s on fatal coordinator errors (apache#18050)" (apache#18544) This reverts commit 70d6312. Reviewers: Luke Chen <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…s on fatal coordinator errors (apache#18050)" (apache#18544) This reverts commit 70d6312. Reviewers: Luke Chen <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…s on fatal coordinator errors (apache#18050)" (apache#18544) This reverts commit 70d6312. Reviewers: Luke Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 70d6312.
The tests timed out in #18050 and the same has been happening in trunk since.
Committer Checklist (excluded from commit message)