Revert "KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch (#17870" #18643
+55
−429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fetch (apache#17870)" This reverts commit b021b51.
AndrewJSchofield
approved these changes
Jan 20, 2025
|
Unrelated test failure on Java 17, build passed on Java 23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b021b51.
The commit was cherry-picked as it was easier to merge subsequent commits in 4.0: #17870 (comment). However, this commit might overwhelm the clients with higher number of records fetched for share-fetch response. We are working towards enhancing share-fetch performance and this commit was among the initial steps which needs to be matured before release hence reverting.
Howeve, I haven't removed the PartitonMaxBytesStrategy classes but just the usage.
Committer Checklist (excluded from commit message)