Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX client java doc compile error #19115

Closed
wants to merge 3 commits into from

Conversation

m1a2st
Copy link
Collaborator

@m1a2st m1a2st commented Mar 5, 2025

It will fail at :clients:javadoc task on CI, fix it

@github-actions github-actions bot added triage PRs from the community clients small Small PRs labels Mar 5, 2025
@m1a2st
Copy link
Collaborator Author

m1a2st commented Mar 5, 2025

~/java_workspace/kafka$ ./gradlew :clients:javadoc

> Configure project :
Starting build with version 4.1.0-SNAPSHOT (commit id b974bba0) using Gradle 8.10.2, Java 17 and Scala 2.13.15
Build properties: ignoreFailures=false, maxParallelForks=32, maxScalacThreads=8, maxTestRetries=0

> Task :clients:processMessages
MessageGenerator: processed 197 Kafka message JSON files(s).

BUILD SUCCESSFUL in 5s
6 actionable tasks: 6 executed
~/java_workspace/kafka$ 

@@ -20,7 +20,7 @@


/**
* Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add import java.util.Map; to fix the "link" too

Copy link
Collaborator

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


> Configure project :
Starting build with version 4.1.0-SNAPSHOT (commit id 485699a1) using Gradle 8.10.2, Java 21 and Scala 2.13.15
Build properties: ignoreFailures=false, maxParallelForks=32, maxScalacThreads=8, maxTestRetries=0

> Task :clients:javadoc
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
 * Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
                                                                            ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
     * Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
                                           ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
     * Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
                                                       ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
     * Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
                                           ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
     * Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
                                                       ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
 * Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
                                                                            ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
 * Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
                                                                            ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
     * Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
                                           ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
     * Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
                                                       ^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
 * Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
                                                                            ^
error: warnings found and -Werror specified
1 error
10 warnings

> Task :clients:javadoc FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':clients:javadoc'.
> Javadoc generation failed. Generated Javadoc options file (useful for troubleshooting): '/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/build/tmp/javadoc/javadoc.options'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

BUILD FAILED in 3s
18 actionable tasks: 2 executed, 16 up-to-date

Still failed

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can run ./gradlew clean build -x test and ./gradlew :clients:javadoc without error.

Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for that, I only saw green checkmarks when merging.

Copy link
Collaborator

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, built successfully on my local.

@lucasbru
Copy link
Member

lucasbru commented Mar 5, 2025

Hey - the change was reverted on trunk instead, we can close thois. Again, sorry for the disturance. It seems CI didn't run at all for that PR

@m1a2st
Copy link
Collaborator Author

m1a2st commented Mar 5, 2025

It seems @mumrah revert that commit, 017692e.

@m1a2st m1a2st closed this Mar 5, 2025
@mumrah
Copy link
Member

mumrah commented Mar 5, 2025

Thanks for the prompt attention to this @m1a2st! I ended up reverting since the CI didn't run at all. If it was just a javadoc breakage, I would be fine with a hotfix like this.

@github-actions github-actions bot removed the triage PRs from the community label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants