-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX client java doc compile error #19115
Conversation
|
@@ -20,7 +20,7 @@ | |||
|
|||
|
|||
/** | |||
* Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add import java.util.Map;
to fix the "link" too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Configure project :
Starting build with version 4.1.0-SNAPSHOT (commit id 485699a1) using Gradle 8.10.2, Java 21 and Scala 2.13.15
Build properties: ignoreFailures=false, maxParallelForks=32, maxScalacThreads=8, maxTestRetries=0
> Task :clients:javadoc
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
* Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
* Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
* Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
* Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
* Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
* Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
* Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
* Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:46: warning: invalid input: '<'
* Return a future which yields all Map<String, Map<TopicPartition, Long> objects, if requests for all the groups succeed.
^
/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:23: warning: invalid usage of tag {@link Admin#alterStreamsGroupOffsets(String groupId, Map),
* Options for the {@link Admin#alterStreamsGroupOffsets(String groupId, Map), AlterStreamsGroupOffsetsOptions)} call.
^
error: warnings found and -Werror specified
1 error
10 warnings
> Task :clients:javadoc FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':clients:javadoc'.
> Javadoc generation failed. Generated Javadoc options file (useful for troubleshooting): '/mnt/f9f8f5b5-8e5f-4347-b9d1-e6362bf7d23e/IdeaProjects/kafka/clients/build/tmp/javadoc/javadoc.options'
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.
BUILD FAILED in 3s
18 actionable tasks: 2 executed, 16 up-to-date
Still failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I can run ./gradlew clean build -x test
and ./gradlew :clients:javadoc
without error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - sorry for that, I only saw green checkmarks when merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, built successfully on my local.
Hey - the change was reverted on trunk instead, we can close thois. Again, sorry for the disturance. It seems CI didn't run at all for that PR |
Thanks for the prompt attention to this @m1a2st! I ended up reverting since the CI didn't run at all. If it was just a javadoc breakage, I would be fine with a hotfix like this. |
It will fail at :clients:javadoc task on CI, fix it