-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-19001: Use streams group-level configurations in heartbeat #19219
Open
lucasbru
wants to merge
16
commits into
apache:trunk
Choose a base branch
from
lucasbru:kip1071merge/heartbeat_4
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic streams group heartbeat handling. - No support for static membership - No support for configurations (using constants instead) - No support for regular expressions
Tests for joining with missing source topics, internal topics, incorrectly partitioned topics, and stale topologies.
In the GroupMetadataManager, we may call an RPC on an incorrect group type. This adds unit tests to validate the behavior when an RPC is used on an incorrect group type.
Implements the use of session timeout, standby tasks and heartbeat interval configurations in the streams group heartbeat. Piggy-backed is another test that streams groups react to changes in the topic metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the use of session timeout, standby tasks and heartbeat interval
configurations in the streams group heartbeat.
Piggy-backed is another test that streams groups react to changes
in the topic metadata
This is a stacked PR. Only review commits starting from "KAFKA-19001: Use streams group-level configurations in heartbeat](798c7d0)"