KAFKA-18736: Add pollOnClose() and maximumTimeToWait() #19233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbru
approved these changes
Mar 24, 2025
| @Override | ||
| public long maximumTimeToWait(long currentTimeMs) { | ||
| pollTimer.update(currentTimeMs); | ||
| if (pollTimer.isExpired() || (membershipManager.shouldNotWaitForHeartbeatInterval() && !heartbeatRequestState.requestInFlight())) { |
cadonna
force-pushed
the
streams_group_heartbeat_request_manager-6
branch
2 times, most recently
from
74283e1 to
4f43a67
Compare
Adds pollOnClose() and maximumTimeToWait() to the Streams group heartbeat request manager.
cadonna
force-pushed
the
streams_group_heartbeat_request_manager-6
branch
from
4f43a67 to
9616493
Compare
ShivsundarR
pushed a commit
to ShivsundarR/kafka
that referenced
this pull request
Mar 26, 2025
Adds pollOnClose() and maximumTimeToWait() to the Streams group heartbeat request manager. Reviewers: Lucas Brutschy <[email protected]>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Mar 31, 2025
Adds pollOnClose() and maximumTimeToWait() to the Streams group heartbeat request manager. Reviewers: Lucas Brutschy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pollOnClose() and maximumTimeToWait() to the Streams
group heartbeat request manager.
Reviewers: Lucas Brutschy [email protected]