Skip to content

MINOR: Remove unnecessary methods #20503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+4 −12
Open

MINOR: Remove unnecessary methods #20503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,16 +492,6 @@ public static MemoryRecordsBuilder builder(ByteBuffer buffer,
false, false, RecordBatch.NO_PARTITION_LEADER_EPOCH, maxSize);
}

public static MemoryRecordsBuilder idempotentBuilder(ByteBuffer buffer,
Compression compression,
long baseOffset,
long producerId,
short producerEpoch,
int baseSequence) {
return builder(buffer, RecordBatch.CURRENT_MAGIC_VALUE, compression, TimestampType.CREATE_TIME,
baseOffset, System.currentTimeMillis(), producerId, producerEpoch, baseSequence);
}

public static MemoryRecordsBuilder builder(ByteBuffer buffer,
byte magic,
Compression compression,
Expand Down
3 changes: 2 additions & 1 deletion ...ts/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,8 @@ public void testFetcherIgnoresControlRecords() {
int partitionLeaderEpoch = 0;

ByteBuffer buffer = ByteBuffer.allocate(1024);
MemoryRecordsBuilder builder = MemoryRecords.idempotentBuilder(buffer, Compression.NONE, 0L, producerId,
MemoryRecordsBuilder builder = MemoryRecords.builder(buffer, RecordBatch.CURRENT_MAGIC_VALUE, Compression.NONE,
TimestampType.CREATE_TIME, 0L, System.currentTimeMillis(), producerId,
producerEpoch, baseSequence);
builder.append(0L, "key".getBytes(), null);
builder.close();
Expand Down
3 changes: 2 additions & 1 deletion clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,8 @@ public void testFetcherIgnoresControlRecords() {
int partitionLeaderEpoch = 0;

ByteBuffer buffer = ByteBuffer.allocate(1024);
MemoryRecordsBuilder builder = MemoryRecords.idempotentBuilder(buffer, Compression.NONE, 0L, producerId,
MemoryRecordsBuilder builder = MemoryRecords.builder(buffer, RecordBatch.CURRENT_MAGIC_VALUE, Compression.NONE,
TimestampType.CREATE_TIME, 0L, System.currentTimeMillis(), producerId,
producerEpoch, baseSequence);
builder.append(0L, "key".getBytes(), null);
builder.close();
Expand Down
Loading