KAFKA-19802: Admin client changes for KIP-1226 #20771
Merged
+182
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
changed the title
AndrewJSchofield
changed the title
lianetm
approved these changes
Nov 3, 2025
| private final Optional<Long> lag; | ||
|
|
||
| /** | ||
| * Construct a new StartPartitionOffsetInfo. |
There was a problem hiding this comment.
Suggested change
| * Construct a new StartPartitionOffsetInfo. | |
| * Construct a new SharePartitionOffsetInfo. |
| * Construct a new StartPartitionOffsetInfo. | ||
| * | ||
| * @param startOffset The share-partition start offset | ||
| * @param leaderEpoch The optional leader epoch of the start offset |
There was a problem hiding this comment.
I expect this is the leader epoch of the share partition, correct?
lianetm
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin client changes for KIP-1226 which adds lag information for share
groups.
Reviewers: Lianet Magrans [email protected]