-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MINOR: added information about KIP-1034, KIP-1153, KIP-1195, and KIP-1230 to the upgrade guide. #20779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…1230 to the upgrade guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Made a pass.
docs/streams/upgrade-guide.html
Outdated
| <p> | ||
| Kafka Streams now supports Dead Letter Queue (DLQ). | ||
| A new config <code>errors.deadletterqueue.topic.name</code> allows to specify the name of the DLQ topic. When set and <code>DefaultProductionExceptionHandler</code> is used, records that cause exceptions will be forwarded to the DLQ topic. | ||
| If a custom exception handler is used, it is up to the custom handler to build DLQ records to send, in this case, the <code>errors.deadletterqueue.topic.name</code> configuration has no impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if "has no impact" is the right phrase to use? -- Users can still access the config and use it, even if I understand that they need to write code for it.
Wondering if we should add something to the docs (separate PR, or just filing a Jira for now), explaining how to actually implement a customer handler correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the phrase from the kip: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+Kafka+Streams under public interfaces.
I will paraphrase it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Matthias J. Sax <[email protected]>
|
Thanks for the PR. Merged to |
Updates Kafka Streams upgrade guide for 4.2.0 release.
Reviewers: Matthias J. Sax [email protected]