KAFKA-19857: Fix CoordinatorExecutorImpl.cancelAll implementation #20808
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was buggy and always threw an IllegalStateException because it called Iterator.remove() without a preceding call to Iterator.next().
github-actions
bot
added
triage
dajac
reviewed
Nov 3, 2025
| public void testTaskCancelledBeforeBeingExecuted() { | ||
| @ParameterizedTest | ||
| @ValueSource(booleans = {false, true}) | ||
| public void testTaskCancelledBeforeBeingExecuted(boolean useCancelAll) { |
There was a problem hiding this comment.
I find the parameterisation weird here. Have you considered having a proper unit test for the method itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was buggy and always threw an
IllegalStateException when there were scheduled tasks because it called
Iterator.remove() without a preceding call to Iterator.next().