Repository navigation
KAFKA-19960: Close pending tasks on shutdown. (#21365) - #21421
Merged
Merged
Conversation
This PR fixes a bug when KS doesn't close stores if the shutdown was triggered during rebalance where an active tasks gets converted to a standby one and put into pendingTasksToInit * Added logic to close pending tasks to init. * Made standby task closure similar to the one for active tasks. * Added a separate method for getting standby tasks from task registry. * Added an integration test that reproduces the issue. Reviewers: Matthias J. Sax <matthias@confluent.io> --------- Co-authored-by: Matthias J. Sax <mjsax@apache.org>
Collaborator
Author
|
cherry pick of #21365 |
Contributor
|
@Nikita-Shupletsov it seems like there are compilation errors: Since tomorrow would be the code freeze for 4.0.2, would you please take a look? |
mjsax
reviewed
Feb 9, 2026
| // and starting the shutdown directly | ||
| // We don't want to let the rebalance finish before we trigger the shutdown, because we want the stream thread to stop before it gets to moving pending tasks from task registry to state updater. | ||
| streams1.close(new KafkaStreams.CloseOptions().leaveGroup(true)); | ||
| streams2.close(new KafkaStreams.CloseOptions().leaveGroup(true)); |
Member
There was a problem hiding this comment.
This doesn't work as expected (that's why it was change in newer release). It only works for static members.
In 4.0, there is an internal config that we should use instead.
mjsax
approved these changes
Feb 9, 2026
Collaborator
Author
|
@viktorsomogyi, @mjsax |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #21365.
This PR fixes a bug when KS doesn't close stores if the shutdown was triggered during rebalance where an active tasks gets converted to a standby one and put into pendingTasksToInit
Conflicts:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
Additional changes:
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RebalanceTaskClosureIntegrationTest.java
Reviewers: Matthias J. Sax matthias@confluent.io