Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes a minor documentation punctuation adjustment in the README, despite the PR description indicating it’s meant to test Gradle report upload behavior across differing JDK versions.
Changes:
- Add an Oxford comma in a README sentence describing Eclipse/Gradle build directory behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
135
to
137
| The `eclipse` task has been configured to use `${project_dir}/build_eclipse` as Eclipse's build directory. Eclipse's default | ||
| build directory (`${project_dir}/bin`) clashes with Kafka's scripts directory and we don't use Gradle's build directory | ||
| build directory (`${project_dir}/bin`) clashes with Kafka's scripts directory, and we don't use Gradle's build directory | ||
| to avoid known issues with this configuration. |
There was a problem hiding this comment.
The PR description mentions testing Gradle report upload with differing JDK versions, but this change set only adjusts punctuation in the README. Please update the PR description to match the actual change (or include the missing functional changes if they were intended).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Test the upload of gradle report when jdk version is difference.