MINOR: Speed up ShareConsumerTest.testAcquisitionLockTimeoutOnConsumer#22537
Open
Russole wants to merge 2 commits into
Open
MINOR: Speed up ShareConsumerTest.testAcquisitionLockTimeoutOnConsumer#22537Russole wants to merge 2 commits into
Russole wants to merge 2 commits into
Conversation
Author
|
Hi @chia7712 , could you please take a look when you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed up
ShareConsumerTest.testAcquisitionLockTimeoutOnConsumerbyoverriding the broker-side share record lock duration for this test.
The test previously relied on the class-level
group.share.record.lock.duration.ms=15000and waited20000msfor theacquisition lock to expire. This PR lowers the test-specific lock
duration to
5000msand reduces the sleep to8000ms.Both
group.share.min.record.lock.duration.msandgroup.share.record.lock.duration.msare set because the actual lockduration must be greater than or equal to the configured minimum.
Reviewers: Chia-Ping Tsai
chia7712@gmail.com
Testing
Ran the target test repeatedly to check for flakiness: