Repository navigation
Conversation
github-actions
Bot
added
tools
tests
chia7712
reviewed
Oct 12, 2026
| @ClusterConfigProperty(key = GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG, value = "1000"), | ||
| @ClusterConfigProperty(key = CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG, value = "500"), | ||
| @ClusterConfigProperty(key = CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG, value = "500"), | ||
| @ClusterConfigProperty(key = "log.initial.task.delay.ms", value = "100"), |
Member
There was a problem hiding this comment.
Personally, I don’t like to add those specific configurations since they look like something magic. Perhaps this PR can refactor that code as well.
- ClusterInstance#deleteTopic should wait for metadata sync only
- the logic of waiting disk sync could be moved to DeleteTopicTest. It is the only user
- remove all those mysterious configurations from other test cases
Member
There was a problem hiding this comment.
Hmm, we already have https://issues.apache.org/jira/browse/KAFKA-21153 to handle that. This PR should wait until that is completed.
m1a2st
reviewed
Oct 15, 2026
m1a2st
left a comment
m1a2st
left a comment
Contributor
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/KAFKA-21153 was already completed in 4abb5a2. @lytt925, please resolve the conflict, thanks.
Preserve KAFKA-21153 logical deletion waits alongside deleteTopic error propagation and remove obsolete cleanup delay overrides. Generated-by: OpenCode (github-copilot/gpt-6.1-sol)
Contributor
Author
Thank you. I've resolved the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23699 to apply the same changes to ClusterInstance#deleteTopic.
ClusterInstance#deleteTopic did not wait for the DeleteTopics result. If the deletion failed, the error was either ignored (e.g. the topic did not exist) or hidden by the waitTopicDeletion timeout. It now calls get() so that the real error can be propagated. As with createTopic, a RuntimeException cause is rethrown as is, and callers no longer need to handle ExecutionException and InterruptedException.
immediately waits for the deletion.
Reviewers: Chia-Ping Tsai chia7712@gmail.com