Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

[LENS-1545]: Fixed Bug in Prepared Query. #35

Open
RajashekharChoukimath wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[LENS-1545]: Fixed Bug in Prepared Query. #35

Changes from 11 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e2cf15b
fixed the memory leak and bug in prepred query
RajashekharInmobi Aug 2, 2019
bfac713
fix for the RNA-14041
RajashekharInmobi Aug 6, 2019
410bfc0
fixed the code review comments
RajashekharInmobi Aug 8, 2019
a56794b
added class for the Prepared Bean
RajashekharInmobi Aug 8, 2019
b7d4f2a
Revert "fixed the memory leak and bug in prepred query"
RajashekharInmobi Aug 13, 2019
0555761
Revert "Revert "fixed the memory leak and bug in prepred query""
RajashekharInmobi Aug 13, 2019
49c9dcb
Revert "added class for the Prepared Bean"
RajashekharInmobi Aug 13, 2019
23125c2
Revert "fixed the code review comments"
RajashekharInmobi Aug 13, 2019
4aa2124
Revert "fix for the RNA-14041"
RajashekharInmobi Aug 13, 2019
570b070
Revert "fixed the memory leak and bug in prepred query"
RajashekharInmobi Aug 13, 2019
37fdb92
Changes in JDBCDriver.java was supposed to happen in #34,
RajashekharInmobi Aug 13, 2019
5482db4
added this line back, because if multiple jdbc drivers(more than one)…
RajashekharInmobi Aug 22, 2019
f13dee2
added jdbc driver changes, removed the code which even makes calls to…
RajashekharInmobi Aug 22, 2019
ee4e066
made 10 minutes back
RajashekharInmobi Aug 22, 2019
40d4fe1
formatting
RajashekharInmobi Aug 29, 2019
cb704e3
formatting
RajashekharInmobi Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,8 @@ public String getPlan() {
public QueryCost estimate(AbstractQueryContext qctx) throws LensException {
MethodMetricsContext validateGauge = MethodMetricsFactory.createMethodGauge(qctx.getDriverConf(this), true,
VALIDATE_GAUGE);
String rewrittenQuery = rewriteQuery(qctx);
Copy link
Contributor

@Amareshwari Amareshwari Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why changes are done in estimate, when you are fixing bug in prepareQuery.

Copy link
Author

@RajashekharChoukimath RajashekharChoukimath Aug 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the azure-world, we are not going to have Lens interacting with the actual underlying drivers. https://docs.google.com/document/d/1K5Q3ZQZAEGkf472DZ_zuLbHZ9ycx86YAEhqbxO0o-aA/edit#

The cleaner way for me is to remove driverconnection which Lens is making for the explain part in prepareInternal Method
https://github.com/apache/lens/blob/master/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java#L728

qctx.setSelectedDriverQuery(rewrittenQuery);
validate(qctx);
validateGauge.markSuccess();
return calculateQueryCost(qctx);
Expand Down