Skip to content

[LIVY-1025] [UT] Clean up Python2InterpreterSpec Test post Python deprecation #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyogal merged 1 commit into from
Dec 4, 2025
Merged

[LIVY-1025] [UT] Clean up Python2InterpreterSpec Test post Python deprecation #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions repl/src/test/scala/org/apache/livy/repl/PythonInterpreterSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,32 +278,7 @@ abstract class PythonBaseInterpreterSpec extends BaseInterpreterSpec {
}
}

class Python2InterpreterSpec extends PythonBaseInterpreterSpec {

implicit val formats = DefaultFormats

override def createInterpreter(): Interpreter = {
val sparkConf = new SparkConf()
PythonInterpreter(sparkConf, new SparkEntries(sparkConf))
}

// Scalastyle is treating unicode escape as non ascii characters. Turn off the check.
// scalastyle:off non.ascii.character.disallowed
it should "print unicode correctly" in withInterpreter { intp =>
intp.execute("print(u\"\u263A\")") should equal(Interpreter.ExecuteSuccess(
TEXT_PLAIN -> "\u263A"
))
intp.execute("""print(u"\u263A")""") should equal(Interpreter.ExecuteSuccess(
TEXT_PLAIN -> "\u263A"
))
intp.execute("""print("\xE2\x98\xBA")""") should equal(Interpreter.ExecuteSuccess(
TEXT_PLAIN -> "\u263A"
))
}
// scalastyle:on non.ascii.character.disallowed
}

class Python3InterpreterSpec extends PythonBaseInterpreterSpec with BeforeAndAfterAll {
class PythonInterpreterSpec extends PythonBaseInterpreterSpec with BeforeAndAfterAll {

implicit val formats = DefaultFormats

Expand Down
2 changes: 0 additions & 2 deletions repl/src/test/scala/org/apache/livy/repl/PythonSessionSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ abstract class PythonSessionSpec extends BaseSessionSpec(PySpark) {
}
}

class Python2SessionSpec extends PythonSessionSpec

class Python3SessionSpec extends PythonSessionSpec with BeforeAndAfterAll {

override protected def withFixture(test: NoArgTest): Outcome = {
Expand Down