[LIVY-1041] Initial changes to provide Scala 2.13 compatibility#530
Open
idzikovsky wants to merge 1 commit into
Open
[LIVY-1041] Initial changes to provide Scala 2.13 compatibility#530idzikovsky wants to merge 1 commit into
idzikovsky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I've stared working on Spark 4 compatibility in my local fork. I don't think that all changes that I've made is applicable to be pushed to the upstream project, but this change I'm confident about.
In this fix I mainly updated usage of collections to be compatible with new redesigned Scala 2.13 collections (so as with older Scala 2.11/2.12 collections).
Also, I replaced invocation of
ServletContext.initParameters()withServletContext.setInitParameter(), because the old wrapper is not compatible with a newjakarta.servlet.ServletContextinterface (Spark 4 migrated from javax to jakarta), whileServletContext.setInitParameter()is version-independent.How was this patch tested?
I run unit tests and manually tested that I'm able to create a Session.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8.