Add two new "Seeded" Knn queries for seeded vector search #14084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….java Co-authored-by: Christine Poerschke <[email protected]>
….java Co-authored-by: Christine Poerschke <[email protected]>
…ry.java Co-authored-by: Christine Poerschke <[email protected]>
…cher.java Co-authored-by: Christine Poerschke <[email protected]>
…cher.java Co-authored-by: Christine Poerschke <[email protected]>
…rQuery.java Co-authored-by: Christine Poerschke <[email protected]>
…rQuery.java Co-authored-by: Christine Poerschke <[email protected]>
…rQuery.java Co-authored-by: Christine Poerschke <[email protected]>
…ry.java Co-authored-by: Christine Poerschke <[email protected]>
…ery.java Co-authored-by: Christine Poerschke <[email protected]>
….java Co-authored-by: Christine Poerschke <[email protected]>
…java Co-authored-by: Christine Poerschke <[email protected]>
…cher.java Co-authored-by: Christine Poerschke <[email protected]>
…cher.java Co-authored-by: Christine Poerschke <[email protected]>
benwtrent
changed the title
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/KnnCollector.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/SeededKnnByteVectorQuery.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
Jan 3, 2025
|
@seanmacavaney @cpoerschke I am gonna merge this in the next couple of days. I flagged the queries and such as experimental if we want to change the interface. But I think it reached a really nice place and is ready for folks to start kicking the tires in more real situations :) |
cpoerschke
reviewed
Jan 8, 2025
lucene/core/src/java/org/apache/lucene/search/SeededKnnByteVectorQuery.java
Outdated
Show resolved
Hide resolved
|
Looks great, thanks @benwtrent! I'm keen to benchmark it a bit, but no need to hold up merging it over that. |
benwtrent
added a commit
that referenced
this pull request
Jan 15, 2025
### Description In some vector search cases, users may already know some documents that are likely related to a query. Let's support seeding HNSW's scoring stage with these documents, rather than using HNSW's hierarchical stage. An example use case is hybrid search, where both a traditional and vector search are performed. The top results from the traditional search are likely reasonable seeds for the vector search. Even when not performing hybrid search, traditional matching can often be faster than traversing the hierarchy, which can be used to speed up the vector search process (up to 2x faster for the same effectiveness), as was demonstrated in [this article](https://arxiv.org/abs/2307.16779) (full disclosure: seanmacavaney is an author of the article). The main changes are: - A new "seeded" focused knn collector and collector manager - Two new basic knn queries that expose using these specialized collectors for seeded entrypoint - `HnswGraphSearcher`, which bypasses the `findBestEntryPoint` step if seeds are provided. //cc @seanmacavaney Co-authored-by: Sean MacAvaney <[email protected]> Co-authored-by: Sean MacAvaney <[email protected]> Co-authored-by: Christine Poerschke <[email protected]>
benwtrent
added a commit
to benwtrent/lucene
that referenced
this pull request
Jan 21, 2025
benwtrent
added a commit
that referenced
this pull request
Jan 22, 2025
benwtrent
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #13635
Description
This PR addresses #13634.
The main changes are in:
HnswGraphSearcher, which bypasses thefindBestEntryPointstep if seeds are provided.//cc @seanmacavaney