Skip to content

[MEDP-964] unconditionally ignore dependencies known to be loaded by reflection #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

[MEDP-964] unconditionally ignore dependencies known to be loaded by reflection #1492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1305fb5
unconditionally ignore dependencies known to be loaded by reflection
elharo Jul 7, 2025
c8dcb37
docs
elharo Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo {
private boolean verbose;

/**
* Ignore Runtime/Provided/Test/System scopes for unused dependency analysis.
* Ignore runtime/provided/test/system scopes for unused dependency analysis.
* <p>
* <code><b>Non-test scoped</b></code> list will be not affected.
*/
@Parameter(property = "ignoreNonCompile", defaultValue = "false")
private boolean ignoreNonCompile;

/**
* Ignore Runtime scope for unused dependency analysis.
* Ignore runtime scope for unused dependency analysis.
*
* @since 3.2.0
*/
Expand Down Expand Up @@ -211,13 +211,18 @@ public abstract class AbstractAnalyzeMojo extends AbstractMojo {
* segment is treated as an implicit wildcard. *
* <p>
* For example, <code>org.apache.*</code> matches all artifacts whose group id starts with
* <code>org.apache.</code>, and <code>:::*-SNAPSHOT</code> will match all snapshot artifacts.
* <code>org.apache.</code>, and <code>:::*-SNAPSHOT</code> matches all snapshot artifacts.
* </p>
*
* <p>Certain dependencies that are known to be used and loaded by reflection
* are always ignored. This includes {@code org.slf4j:slf4j-simple::}.</p>
*
* @since 2.10
*/
@Parameter(defaultValue = "org.slf4j:slf4j-simple::")
private String[] ignoredUnusedDeclaredDependencies;
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];

private String[] unconditionallyIgnoredDeclaredDependencies = {"org.slf4j:slf4j-simple::"};

/**
* List of dependencies that are ignored if they are in not test scope but are only used in test classes.
Expand Down Expand Up @@ -361,6 +366,7 @@ private boolean checkDependencies() throws MojoExecutionException {

ignoredUnusedDeclared.addAll(filterDependencies(unusedDeclared, ignoredDependencies));
ignoredUnusedDeclared.addAll(filterDependencies(unusedDeclared, ignoredUnusedDeclaredDependencies));
ignoredUnusedDeclared.addAll(filterDependencies(unusedDeclared, unconditionallyIgnoredDeclaredDependencies));

if (ignoreAllNonTestScoped) {
ignoredNonTestScope.addAll(filterDependencies(nonTestScope, new String[] {"*"}));
Expand Down