Open
Conversation
KrisJohnstone
force-pushed
the
arm64-builds
branch
from
392ee48 to
8790d37
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose 2.28 as RHEL8 and Ubuntu 18.04 LTS both still use this version afaik and are the oldest operating systems I know of that are still under support of some sort.
Could use 2.17 as that's when support for ARM64 was added from what I can see, but there were also test failures in versions 2.18 etc so figured best case is to choose a later version, which is when I settled on using the newest version supported by the oldest operating system.
I can't test the github actions from a fork but it should work, I've verified that the content of the steps works, its the conditionals on the steps I'm not 100% on.