Skip to content

Match maven-shared-archive-resources on the last path segment #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kratos0718 wants to merge 3 commits into from
+113 −2
Closed

Match maven-shared-archive-resources on the last path segment #317

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78a98f3
Match maven-shared-archive-resources on the last path segment
kratos0718 Aug 4, 2026
e319dd4
Inline the directory name literal
kratos0718 Aug 5, 2026
4c92d96
Add tests for the shared archive resources directory match
kratos0718 Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/main/java/org/apache/maven/plugins/source/AbstractSourceJarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ public abstract class AbstractSourceJarMojo implements Mojo {

private static final String[] DEFAULT_EXCLUDES = new String[] {};

/**
* Name of the directory produced by maven-remote-resources-plugin whose contents are added to
* the source archive. Matched against the last path segment, not the whole path.
*/
private static final String SHARED_ARCHIVE_RESOURCES = "maven-shared-archive-resources";

@elharo elharo Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline this as it's only used in one place


/**
* List of files to include. Specified as fileset patterns which are relative to the input directory whose contents
* is being packaged into the JAR.
Expand Down Expand Up @@ -431,10 +437,12 @@ protected MavenArchiver createArchiver() throws MojoException {
project.getBuild().getResources();

for (org.apache.maven.api.model.Resource r : resources) {
if (r.getDirectory().endsWith("maven-shared-archive-resources")) {
Path resourceDirectory = Paths.get(r.getDirectory());
Path directoryName = resourceDirectory.getFileName();
if (directoryName != null && SHARED_ARCHIVE_RESOURCES.equals(directoryName.toString())) {
addDirectory(
archiver.getArchiver(),
Paths.get(r.getDirectory()),
resourceDirectory,
getCombinedIncludes(null),
getCombinedExcludes(null));
}
Expand Down
Loading