add some ignore in dependabot configuration#3286
Conversation
Signed-off-by: Olivier Lamy <[email protected]>
|
You opened a PR without properly saying why we need to have these changes in depenabot. What happened? |
|
I've added some self-explanatory comments directly in the dependabot.yml file to clarify the rules. |
.github/dependabot.yml
Outdated
| - package-ecosystem: "maven" | ||
| target-branch: "master" | ||
| commit-message: | ||
| prefix: "[Master]" |
There was a problem hiding this comment.
In most of Maven project we use labels for such things ... so for me will be good to have some conventions, some of commits will have a prefix according to branch, but commits/PR doing manually probably will not have it
There was a problem hiding this comment.
Whatever label or prefix, as long as we can see the difference quickly when looking at /pulls. The advantage of a prefix is to see this directly when using gh pr list.
But no real strong opinion.
Signed-off-by: Olivier Lamy <[email protected]>
.github/dependabot.yml
Outdated
| labels: | ||
| - master |
There was a problem hiding this comment.
we need to add all labels, so please also add here dependencies and java
There was a problem hiding this comment.
we also need manually add new label master to https://github.com/apache/maven-surefire/labels
dependabot will not create it
.github/dependabot.yml
Outdated
| labels: | ||
| - master |
There was a problem hiding this comment.
please add dependencies and github_actions
There was a problem hiding this comment.
done.
sounds weird to have dependencies and github_actions as the same time though.
There was a problem hiding this comment.
it is default, but when we override default is not used
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy [email protected]
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.