Skip to content

add some ignore in dependabot configuration#3286

Merged
olamy merged 4 commits intoapache:masterfrom
olamy:tidy-up-dependabot
Mar 1, 2026
Merged

add some ignore in dependabot configuration#3286
olamy merged 4 commits intoapache:masterfrom
olamy:tidy-up-dependabot

Conversation

@olamy
Copy link
Member

@olamy olamy commented Feb 26, 2026

Signed-off-by: Olivier Lamy [email protected]

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy added the skip-changelog Skip this PR from automatically changelog generation label Feb 26, 2026
@olamy olamy self-assigned this Feb 26, 2026
@Tibor17
Copy link
Contributor

Tibor17 commented Feb 28, 2026

You opened a PR without properly saying why we need to have these changes in depenabot. What happened?
There's a default template but nothing else, rewrite the text. Nobody knows what you are doing and why.

@Tibor17 Tibor17 self-requested a review February 28, 2026 00:01
@olamy
Copy link
Member Author

olamy commented Feb 28, 2026

I've added some self-explanatory comments directly in the dependabot.yml file to clarify the rules.
But I'm happy to add even more content here if the comments are not self-explanatory enough.
This is a standard configuration approach for projects with strict baseline requirements (like Java 8).
Without these exclusions, Dependabot would suggest incompatible upgrades, as seen here: #3287 or #3283 .
This setup simply prevents such noise.
I also added exclusions for dependencies like slf4j-api and maven-resolver (with inline comments explaining why). Since these are tied to Maven Core, they cannot be upgraded independently.

@olamy olamy requested a review from Bukama February 28, 2026 09:26
- package-ecosystem: "maven"
target-branch: "master"
commit-message:
prefix: "[Master]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most of Maven project we use labels for such things ... so for me will be good to have some conventions, some of commits will have a prefix according to branch, but commits/PR doing manually probably will not have it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever label or prefix, as long as we can see the difference quickly when looking at /pulls. The advantage of a prefix is to see this directly when using gh pr list.
But no real strong opinion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to use label

@olamy olamy requested a review from slawekjaranowski March 1, 2026 10:57
Comment on lines +21 to +22
labels:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add all labels, so please also add here dependencies and java

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need manually add new label master to https://github.com/apache/maven-surefire/labels
dependabot will not create it

Comment on lines +40 to +41
labels:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add dependencies and github_actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.
sounds weird to have dependencies and github_actions as the same time though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is default, but when we override default is not used

olamy added 2 commits March 1, 2026 21:09
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy merged commit 8c577f0 into apache:master Mar 1, 2026
14 checks passed
@olamy olamy deleted the tidy-up-dependabot branch March 1, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants