Skip to content

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Sep 26, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

enabler for:

@Pankraz76 Pankraz76 marked this pull request as ready for review September 26, 2025 15:15
@slachiewicz
Copy link
Member

please apply spotless and make sure that tests will pass

@Pankraz76 Pankraz76 force-pushed the fix-forbidWildcardImports branch from d8e23d0 to 997928b Compare September 27, 2025 17:51
@Pankraz76
Copy link
Contributor Author

yes please excuse my oversight.

executed without changes, wondering why so.
image

@Pankraz76
Copy link
Contributor Author

IO: Caused by: java.net.http.HttpConnectTimeoutException: HTTP connect timed out

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It clearly breaks the build... ;-)

@Pankraz76
Copy link
Contributor Author

yes also compile, even tho clean verify did pass the build locally.

[INFO] /Users/runner/work/maven/maven/src/graph/ReactorGraph.java:257: error: cannot find symbol.

@Pankraz76 Pankraz76 force-pushed the fix-forbidWildcardImports branch from 997928b to 2ade034 Compare September 29, 2025 11:26
@Pankraz76
Copy link
Contributor Author

lets just try this and or close waiting for parent pull just to apply what spotless is pointing out.

@gnodet gnodet merged commit 267a207 into apache:master Sep 29, 2025
19 checks passed
@github-actions github-actions bot added this to the 4.1.0 milestone Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants