Document deprecation of Language.SCRIPT #11579
Conversation
|
Gentle ping 🙂 |
|
Just checking in on this PR. It has been idle for a while and is still awaiting workflow approval and review. |
| * This constant is retained for backward compatibility with Maven 3. | ||
| * | ||
| * @deprecated Use {@link #RESOURCES} instead. | ||
| * @deprecated Since Maven 4.0.0-alpha. |
There was a problem hiding this comment.
do we need Since Maven 4.0.0-alpha. here?
| * Use {@link #RESOURCES} instead. | ||
| */ | ||
| @Deprecated | ||
| @Deprecated(since = "4.0.0-alpha", forRemoval = false) |
There was a problem hiding this comment.
I don't know that we want to specify alpha versions in since paramters. 4.0.0 is enough
There was a problem hiding this comment.
@elharo Updated as suggested. I’ve removed the alpha reference and used @deprecated(since = "4.0.0") without duplicating version information in the Javadoc. Please let me know if anything else needs adjustment.
There was a problem hiding this comment.
It still says alpha,. 4.0.0 is better
| * Use {@link #RESOURCES} instead. | ||
| */ | ||
| @Deprecated | ||
| @Deprecated(since = "4.0.0-alpha", forRemoval = false) |
There was a problem hiding this comment.
It still says alpha,. 4.0.0 is better
|
Fixed — replaced the plain @deprecated with @deprecated(since = "4.0.0"). |
2 participants
Summary
Improves documentation for the deprecated
Language.SCRIPTconstant.Motivation
Language.SCRIPTis deprecated but lacked structured deprecation metadata.This change clarifies the rationale, adds
sinceinformation, and documentsthe recommended replacement.
Changes
@Deprecated(since = "4.0.0-alpha", forRemoval = false)Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Note: This change is documentation-only and does not affect runtime behavior.