Skip to content

Document deprecation of Language.SCRIPT #11579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anukalp2804 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

Document deprecation of Language.SCRIPT #11579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions api/maven-api-core/src/main/java/org/apache/maven/api/Language.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,14 @@ public interface Language extends ExtensibleEnum {
Language RESOURCES = language("resources");

/**
* The "script" language. Provided for compatibility with Maven 3.
* The {@code "script"} language.
* <p>
* This constant is retained for backward compatibility with Maven 3.
*
* @deprecated Use {@link #RESOURCES} instead.
* @deprecated Since Maven 4.0.0-alpha.
Copy link
Contributor

@elharo elharo Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need Since Maven 4.0.0-alpha. here?

* Use {@link #RESOURCES} instead.
*/
@Deprecated
@Deprecated(since = "4.0.0-alpha", forRemoval = false)
Copy link
Contributor

@elharo elharo Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that we want to specify alpha versions in since paramters. 4.0.0 is enough

Copy link
Contributor Author

@anukalp2804 anukalp2804 Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elharo Updated as suggested. I’ve removed the alpha reference and used @deprecated(since = "4.0.0") without duplicating version information in the Javadoc. Please let me know if anything else needs adjustment.

Copy link
Contributor

@elharo elharo Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still says alpha,. 4.0.0 is better

Language SCRIPT = language("script");

// TODO: this should be moved out from here to Java Support (builtin into core)
Expand Down