Skip to content

Improve error message for unresolved expressions #11615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaoSSR wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve error message for unresolved expressions #11615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da7d466
Improve error message for unresolved expressions
GaoSSR Dec 31, 2025
1bafff2
Fix Spotless formatting violations
GaoSSR Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 59 additions & 1 deletion impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ public DependencyResolverResult collect(@Nonnull DependencyResolverRequest reque
session.getNode(result.getRoot(), request.getVerbose()),
0);
} catch (DependencyCollectionException e) {
throw new DependencyResolverException("Unable to collect dependencies", e);
String enhancedMessage = enhanceCollectionError(e, collectRequest);
throw new DependencyResolverException(enhancedMessage, e);
Copy link
Contributor

@Pankraz76 Pankraz76 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new DependencyResolverException(enhancedMessage, e);
throw new DependencyResolverException(enhanceCollectionError(e, collectRequest), e);

Copy link
Contributor

@elharo elharo Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as is

}
} finally {
RequestTraceHelper.exit(trace);
Expand Down Expand Up @@ -274,4 +275,61 @@ public DependencyResolverResult resolve(DependencyResolverRequest request)
private static DependencyResolverException cannotReadModuleInfo(final Path path, final IOException cause) {
return new DependencyResolverException("Cannot read module information of " + path, cause);
}

private static boolean containsUnresolvedExpression(String value) {
return value != null && value.contains("${") && value.contains("}");
}

private static String enhanceCollectionError(DependencyCollectionException e, CollectRequest request) {
if (e.getMessage() != null && e.getMessage().contains("Invalid Collect Request")) {
StringBuilder enhanced = new StringBuilder();
enhanced.append("Failed to collect dependencies");

org.eclipse.aether.graph.Dependency root = request.getRoot();
if (root != null && root.getArtifact() != null) {
Copy link
Contributor

@Pankraz76 Pankraz76 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (root != null && root.getArtifact() != null) {
return if (root != null && root.getArtifact() != null) ? enhanceDependency() : enhanceDependencies(...);

could be extracted as dedicated branch/concern to provide cohesion over coupling.

Copy link
Contributor

@elharo elharo Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ternary operators are harder to read

Copy link
Contributor

@Pankraz76 Pankraz76 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when correctly formatted its actually just like code structure below: just with different character.

Image

Copy link
Contributor

@Pankraz76 Pankraz76 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

org.eclipse.aether.artifact.Artifact artifact = root.getArtifact();
String groupId = artifact.getGroupId();
String artifactId = artifact.getArtifactId();
String version = artifact.getVersion();

if (containsUnresolvedExpression(groupId)
|| containsUnresolvedExpression(artifactId)
|| containsUnresolvedExpression(version)) {
enhanced.append(" due to unresolved expression(s) in dependency: ")
.append(groupId)
.append(":")
.append(artifactId)
.append(":")
.append(version)
.append(".\n")
.append("Please check that all properties are defined in your POM or settings.xml.");
return enhanced.toString();
}
}

for (org.eclipse.aether.graph.Dependency dep : request.getDependencies()) {
Copy link
Contributor

@Pankraz76 Pankraz76 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be extracted as dedicated branch/concern to provide cohesion over coupling.

Suggested change
for (org.eclipse.aether.graph.Dependency dep : request.getDependencies()) {
return enhanceDependencies(...)

if (dep != null && dep.getArtifact() != null) {
org.eclipse.aether.artifact.Artifact artifact = dep.getArtifact();
String groupId = artifact.getGroupId();
String artifactId = artifact.getArtifactId();
String version = artifact.getVersion();

if (containsUnresolvedExpression(groupId)
|| containsUnresolvedExpression(artifactId)
|| containsUnresolvedExpression(version)) {
enhanced.append(" due to unresolved expression(s) in dependency: ")
.append(groupId)
.append(":")
.append(artifactId)
.append(":")
.append(version)
.append(".\n")
.append("Please check that all properties are defined in your POM or settings.xml.");
return enhanced.toString();
}
}
}
}
return e.getMessage();
}
}