crypto/mbedtls: Add unit test for mynewt GCM #3391
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gorecki
force-pushed
the
gcm-mynewt-test
branch
from
75bbf43 to
7143caf
Compare
sjanc
reviewed
Mar 20, 2025
| } | ||
|
|
||
| rc = mbedtls_gcm_finish(&ctx, test_tag, sizeof(test_tag)); | ||
| out: |
There was a problem hiding this comment.
nitpick: I'd prefer label to be top level (no indent), for visibility
m-gorecki
force-pushed
the
gcm-mynewt-test
branch
2 times, most recently
from
dc09ec0 to
74e8096
Compare
This adds unit test for additional mynewt GCM related APIs
m-gorecki
force-pushed
the
gcm-mynewt-test
branch
from
74e8096 to
b41dd7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit test for additional mynewt GCM related APIs