apps: bttester: Implement notify / Remove set_mult #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-czapracki
force-pushed
the
notify_mult
branch
5 times, most recently
from
2bc0f0f to
153b898
Compare
szymon-czapracki
changed the title
sjanc
requested changes
Mar 20, 2025
apps/bttester/src/btp/btp_gatt.h
Outdated
| uint16_t count; | ||
| uint8_t data[0]; | ||
| uint16_t data[0]; |
apps/bttester/src/btp_gatt.c
Outdated
|
|
||
| os_mbuf_append(tuples[i].value, cp->data + data_idx, data_len); | ||
| data_idx += data_len; | ||
| if (cp->count > sizeof(cb_data.handles)) { |
There was a problem hiding this comment.
while you are at is please also add size validations for btp command since it is declared BTP_HANDLER_LENGTH_VARIABLE
if (cmd_len < sizeof(*cp) || cmd_len != (sizeof(*cp) + (le16toh(cp->count)) * sizeof(cp->handles[0])))) { return failed;}
apps/bttester/src/btp_gatt.c
Outdated
|
|
||
| os_mbuf_append(tuples[i].value, cp->data + data_idx, data_len); | ||
| data_idx += data_len; | ||
| if (cp->count > sizeof(cb_data.handles)) { |
szymon-czapracki
force-pushed
the
notify_mult
branch
2 times, most recently
from
11b505e to
98912b5
Compare
Add functionality to utilize BTP notify multiple command. Existing notify handling parses non-existent data.
This command has no corresponding auto-pts procedure. Notify is now utilized via function specially designed for notify purpose.
szymon-czapracki
force-pushed
the
notify_mult
branch
from
98912b5 to
fd3860b
Compare
sjanc
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to utilize BTP notify multiple command.
Previous notify handling via set_mult parses non-existent data.