apps: bttester: refactor notifications and indications #1966
+39
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrnarajowski
changed the title
Removes os_callout_init from tester_init_gatt and variables and funcitons related to it. Notifications/indications were sent right after peer has subscribed for notification (or indication). This will be now handled by calling set_value btp command implemented in another commit.
Opcode 0x06 and btp_cmd struct were previously defined in btp_gatt.h but command implementation was missing. Can be used to send notifications or indications.
piotrnarajowski
force-pushed
the
set_val_btp
branch
from
13d30ee to
b2f434b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes os_callout_init from tester_init_gatt and variables and funcitons related to it. Notifications/indications were sent right after peer has subscribed for notification (or indication). This will be now handled by calling set_value btp command
Note: this can be tested by running GATT/SR/GAN/BV-01-C or GATT/SR/GAI/BV-01-C test case but will require changes from auto-pts/auto-pts#1361 to be merged