host: prevent timing issue if indication ack is received before proc being inserted #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienEspitallier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using nimBLE on an ESP32 project.
Due to high CPU usage and (maybe wrong ?) task priority configuration, I sometimes have ble_gatts_rx_indicate_rsp not finding the proc because it is called before ble_gatts_indicate_custom has a chance to call ble_gattc_process_status.
This lead nimble to closes the connection 30s later as the proc timer expires.
This PR proposes to add the proc to the list before calling the tx function, and remove it if tx fails.