nimble/ll: Introduce ble_ll_addr #2015
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
ll-addr
branch
2 times, most recently
from
54f3d7c to
9101a1f
Compare
This introduces new ble_ll_addr module which should be used to keep track of addressed used by NimBLE LL. For now we just move globals g_dev_addr and g_random_addr to this file, but eventually those variables should be static and accessed only via setters and getters.
This adds 2 new APIs that can be implemented by packages: provide public or static device address. This allows for better support of provisioning of Bluetooth devices address on different devices. The nrf5x driver can act as a provider of both public and static address which is configurable by syscfg settings. By default provider for a static address is enabled since all nRF5x have factory programmed random address in FICR registers. The provider for a public address can be optionally enabled since the same registers can be also be factory programmed with a public address (on request).
This adds an option to initialize random device address by default using an address retrieved from an address provider.
Modules from u-blox AG are preprogrammed with a valid public device address stored in UICR registers. This package makes this address usable by NimBLE LL.
andrzej-kaczmarek
force-pushed
the
ll-addr
branch
from
9101a1f to
d10b886
Compare
The public device address set by this command is applied only after HCI Reset, thus it can be issues at any time. To revert back to original public address set address to 0x000000000000.
andrzej-kaczmarek
force-pushed
the
ll-addr
branch
from
d10b886 to
1415c54
Compare
In general we should pass any addr parameter to function as const since we only rarely need to modify its contents and the address itself may point to our device address which we never want to be able to modify from outsied ble_ll_addr by mistake...
andrzej-kaczmarek
force-pushed
the
ll-addr
branch
from
1415c54 to
9e2093c
Compare
We should now only use helpers from ble_ll_addr to access public and random addresses across all LL code.
andrzej-kaczmarek
force-pushed
the
ll-addr
branch
from
9e2093c to
9199f36
Compare
sjanc
reviewed
Apr 9, 2025
There was a problem hiding this comment.
I'm fine in general with this change.
Just wonder if we shouldn't do provisioning API the other way around ie. API that would be called from provider towards LL.
eg addr_ublox would have init that would call ble_ll_addr_provide_public(const *addr) and set expected value for LL, and not LL calling externally implemented function
|
ok, after rethinking this using newt pkg APIs is also fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.