Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread: remove enter_critical_section in pthread_mutex #15126

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

hujun260
Copy link
Contributor

@hujun260 hujun260 commented Dec 11, 2024

Summary

pthread: remove enter_critical_section in pthread_mutex

reason:
We would like to replace the critical section with a small lock.

Impact

pthread

Testing

ci ostest

@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Dec 11, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 11, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a reason for the change and identifies a related PR, it lacks crucial information.

Here's what's missing:

  • Insufficient Summary: The summary needs to be more detailed. It should explain how the change works (the mechanism of replacing the critical section) and what functional part of the code is affected beyond just "pthread."
  • Missing Impact Details: Simply stating "pthread" is not enough. The impact section requires YES/NO answers for all listed items (user impact, build impact, hardware impact, documentation, security, compatibility). If any answer is YES, a description is mandatory. For example, even if the answer to "Impact on user" is NO, you should still explicitly state "NO".
  • Inadequate Testing Information: "ci ostest" is insufficient. The requirements ask for:
    • Specific build host details (OS, CPU, compiler version).
    • Specific target details (architecture, board, configuration).
    • Actual testing logs before and after the change, not just a reference to CI. While CI is important, the PR should demonstrate local verification.

Therefore, the PR needs substantial revision to meet the stated requirements before it can be properly reviewed.

sched/pthread/pthread_mutex.c Outdated Show resolved Hide resolved
sched/pthread/pthread_mutex.c Outdated Show resolved Hide resolved
@hujun260 hujun260 force-pushed the apache_1 branch 2 times, most recently from 1c2754b to 87de18d Compare December 13, 2024 03:44
reason:
We would like to replace the critical section with a small lock.

Signed-off-by: hujun5 <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 5f4a15b into apache:master Jan 12, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants