armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 #15550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: arm
reason: In kernel mode, sighand_test() may failed. because nxsig_unmask_pendingsignal may change tcb->xcp.regs,and we should update return value(regs). Signed-off-by: hujun5 <[email protected]>
xiaoxiang781216
approved these changes
Jan 15, 2025
|
@hujun260 please review other similar places to ensure all same problems get fixed. |
ok |
|
@yf13 This pr fix the issue you mentioned in kernel mode |
thanks, now the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
armv7a/r: fix regression from #14596
reason:
In kernel mode, sighand_test() may failed.
because nxsig_unmask_pendingsignal may change tcb->xcp.regs,and we should update return value(regs).
Impact
armv7a/r kernel mode
Testing
ci