chore: reduce duplicated code for hdfs #5044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 28, 2024
|
|
||
| Ok(RpDelete::default()) | ||
| async fn delete(&self, path: &str, args: OpDelete) -> Result<RpDelete> { | ||
| self.blocking_delete(path, args) |
There was a problem hiding this comment.
Thank you very much for this change. However, it's not advisable to use a blocking API call directly (even though we currently do it this way). The ideal approach is to add an async API in hdrs first.
|
Hi, @yjhmelody thank you for the contribution. I'm going to close this PR as the code here is not duplicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?