Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/hdfs_native): implement write/read/list methods #5617

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(services/hdfs_native): implement write/read/list methods #5617

wants to merge 11 commits into from
+74 −25

Conversation

zhaohaidao
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@zhaohaidao zhaohaidao requested a review from Xuanwo as a code owner February 9, 2025 05:17
@zhaohaidao zhaohaidao changed the title feat(hdfs_native): implement HdfsNativeWriter write and close method (WIP)feat(hdfs_native): implement HdfsNativeWriter write and close method Feb 9, 2025
@zhaohaidao
Copy link
Contributor Author

@Xuanwo Hi, where can I add test cases for newly submitted code?

@zhaohaidao zhaohaidao changed the title (WIP)feat(hdfs_native): implement HdfsNativeWriter write and close method (WIP)feat(hdfs_native): implement HdfsNativeWriter write/read/list methods Feb 9, 2025
@zhaohaidao zhaohaidao changed the title (WIP)feat(hdfs_native): implement HdfsNativeWriter write/read/list methods (WIP)feat(services/hdfs_native): implement write/read/list methods Feb 9, 2025
@zhaohaidao
Copy link
Contributor Author

@Xuanwo Hi, where can I add test cases for newly submitted code?

ping @Xuanwo

Xuanwo
Xuanwo reviewed Feb 12, 2025
View reviewed changes
core/src/services/hdfs_native/lister.rs Show resolved Hide resolved
core/src/services/hdfs_native/reader.rs Outdated Show resolved Hide resolved
core/src/services/hdfs_native/writer.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Feb 12, 2025

@Xuanwo Hi, where can I add test cases for newly submitted code?

OpenDAL performs behavior tests on all services. Please check https://github.com/apache/opendal/blob/main/core/tests/behavior/README.md for more details.

@zhaohaidao
Copy link
Contributor Author

@Xuanwo Hi, where can I add test cases for newly submitted code?

OpenDAL performs behavior tests on all services. Please check https://github.com/apache/opendal/blob/main/core/tests/behavior/README.md for more details.

I have a question. These methods were not actually implemented before. How did the test cases pass?

@zhaohaidao zhaohaidao changed the title (WIP)feat(services/hdfs_native): implement write/read/list methods feat(services/hdfs_native): implement write/read/list methods Feb 12, 2025
@zhaohaidao
Copy link
Contributor Author

@Xuanwo Hi, where can I add test cases for newly submitted code?

OpenDAL performs behavior tests on all services. Please check https://github.com/apache/opendal/blob/main/core/tests/behavior/README.md for more details.

I have another question. I can't find the problem of CI when I run clippy locally. Do you have any troubleshooting suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaohaidao @Xuanwo