Skip to content

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Dec 29, 2023

Context

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne
Copy link
Contributor Author

FYI @amensiko - I just rebased the branch on OPENNLP-855 from 2017. Could drop your comment on its state, pls?
From what I can see, the code changes you provided are still compatible with OpenNLP in 2023.

@mawiesne
Copy link
Contributor Author

Note: Tests required.

@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch 2 times, most recently from b9f82fb to a0526b4 Compare July 9, 2024 14:10
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from a0526b4 to 3616cb7 Compare October 24, 2024 09:30
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from 3616cb7 to dc57749 Compare December 27, 2024 17:04
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from dc57749 to e46c576 Compare January 10, 2025 10:14
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from e46c576 to f70c874 Compare April 17, 2025 19:18
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from f70c874 to eddcb8a Compare June 7, 2025 19:26
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from eddcb8a to 28c78a4 Compare June 18, 2025 15:48
@mawiesne mawiesne added the java Pull requests that update Java code label Jun 18, 2025
amensiko and others added 2 commits July 9, 2025 09:38
- adapts existing Sentiment code to OpenNLP 3.x module structures
- introduces SentimentDetector API interface
@mawiesne mawiesne force-pushed the OPENNLP-855-Sentiment-from-text branch from 28c78a4 to 17ea957 Compare July 9, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant