Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address bug 127942 #251

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Address bug 127942 #251

wants to merge 3 commits into from

Conversation

ardovm
Copy link
Contributor

@ardovm ardovm commented Jan 19, 2025

See bug 127942 for information.

ardovm added 2 commits January 19, 2025 22:16
@ardovm
File and URL history elements disappear when cleared
afd9e31 
Allow configuration elements to disappear by becoming "wiped"-type
nodes.
Intercept the removal of file and URL history elements and turn them into
"wiped" nodes.
@ardovm
Clear URL history together with recent files
8eeb065
@Pilot-Pirx Pilot-Pirx self-requested a review January 24, 2025 14:28
@Pilot-Pirx
Copy link
Member

Windows build went fine.
But after clearing the recent file list the URL history is still populated...
After closing and reopening the URL history is clean.

@ardovm
Copy link
Contributor Author

ardovm commented Jan 24, 2025

There are other problems, unfortunately. When the history is cleared, it does not get populated again (visited documents are not saved) until the program is restarted.
This cannot be merged as is.

@ardovm ardovm marked this pull request as draft January 24, 2025 23:23
@ardovm
Revert "wiped" nodes and avoid saving history elements
13d3b75 
Avoid recording "removed" elements with certain paths, corresponding to
histories.

The KIND_WIPED nodes were a bad idea as they just created confusion.
Configuration element must be removed, not replaced.
@ardovm ardovm marked this pull request as ready for review January 27, 2025 22:05
@ardovm
Copy link
Contributor Author

ardovm commented Jan 27, 2025

Logic changed: configuration elements are removed as usual, but if their "parent path" matches the history settings, they are not saved as "removed".

@ardovm
Copy link
Contributor Author

ardovm commented Jan 27, 2025

[...] But after clearing the recent file list the URL history is still populated... After closing and reopening the URL history is clean.

Apparently, configuration file registrymodifications.xcu is saved asynchronously. It may take some (seconds? minutes?) after the user clears the history, for the file to be written to disk.

@Pilot-Pirx
Copy link
Member

Apparently, configuration file registrymodifications.xcu is saved asynchronously. It may take some (seconds? minutes?) after the user clears the history, for the file to be written to disk.

Maybe that can be forced somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilot-Pirx Pilot-Pirx Awaiting requested review from Pilot-Pirx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardovm @Pilot-Pirx