Skip to content

workaround stray whitespace in sst index #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjfanning merged 3 commits into from
Aug 5, 2025
Merged

workaround stray whitespace in sst index #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70078d4
tolerate whitespace in ints
pjfanning Aug 5, 2025
0cbc1cc
try to workaround stray whitespace in sst index
pjfanning Aug 5, 2025
6b2e365
Update TestAllFiles.java
pjfanning Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ public class TestAllFiles {
// stress docs
"document/deep-table-cell.docx",

// invalid files
"spreadsheet/bug69769.xlsx",

// NOTE: Expected failures should usually be added in file "stress.xls" instead
// of being listed here in order to also verify the expected exception details!
};
Expand Down
21 changes: 14 additions & 7 deletions poi-ooxml/src/main/java/org/apache/poi/xssf/eventusermodel/XSSFSheetXMLHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public void startElement(String uri, String localName, String qName,
} else if ("row".equals(localName)) {
String rowNumStr = attributes.getValue("r");
if (rowNumStr != null) {
rowNum = Integer.parseInt(rowNumStr) - 1;
rowNum = parseInt(rowNumStr) - 1;
} else {
rowNum = nextRowNum;
}
Expand Down Expand Up @@ -284,7 +284,7 @@ else if ("str".equals(cellType))
XSSFCellStyle style = null;
if (stylesTable != null) {
if (cellStyleStr != null) {
int styleIndex = Integer.parseInt(cellStyleStr);
int styleIndex = parseInt(cellStyleStr);
style = stylesTable.getStyleAt(styleIndex);
} else if (stylesTable.getNumCellStyles() > 0) {
style = stylesTable.getStyleAt(0);
Expand Down Expand Up @@ -392,7 +392,7 @@ private void outputCell() {
if (this.formatString != null) {
try {
// Try to use the value as a formattable number
double d = Double.parseDouble(fv);
double d = parseDouble(fv);
thisStr = formatter.formatRawCellContents(d, this.formatIndex, this.formatString);
} catch (Exception e) {
// Formula is a String result not a Numeric one
Expand All @@ -416,10 +416,10 @@ private void outputCell() {
break;

case SST_STRING:
String sstIndex = value.toString();
String sstIndex = value.toString().trim();
if (!sstIndex.isEmpty()) {
try {
int idx = Integer.parseInt(sstIndex);
int idx = parseInt(sstIndex);
RichTextString rtss = sharedStringsTable.getItemAt(idx);
thisStr = rtss.toString();
} catch (NumberFormatException ex) {
Expand All @@ -433,7 +433,7 @@ private void outputCell() {
if (this.formatString != null && !n.isEmpty()) {
try {
thisStr = formatter.formatRawCellContents(
Double.parseDouble(n), this.formatIndex, this.formatString);
parseDouble(n), this.formatIndex, this.formatString);
} catch (Exception e) {
LOG.atInfo().log(
"Error formatting cell '{}' - will use its raw value instead (format '{}')",
Expand Down Expand Up @@ -515,7 +515,6 @@ private void checkForEmptyCellComments(EmptyCellCommentsCheckType type) {
}
}


/**
* Output an empty-cell comment.
*/
Expand All @@ -524,6 +523,14 @@ private void outputEmptyCellComment(CellAddress cellRef) {
output.cell(cellRef.formatAsString(), null, comment);
}

private static int parseInt(String value) throws NumberFormatException {
return Integer.parseInt(value.trim());
}

private static double parseDouble(String value) throws NumberFormatException {
return Double.parseDouble(value.trim());
}

private enum EmptyCellCommentsCheckType {
CELL,
END_OF_ROW,
Expand Down
23 changes: 18 additions & 5 deletions poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFCell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Licensed to the Apache Software Foundation (ASF) under one or more
import java.util.Calendar;
import java.util.Date;

import org.apache.logging.log4j.Logger;
import org.apache.poi.logging.PoiLogManager;
import org.apache.poi.ss.SpreadsheetVersion;
import org.apache.poi.ss.formula.FormulaParser;
import org.apache.poi.ss.formula.FormulaRenderer;
Expand Down Expand Up @@ -73,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
*/
public final class XSSFCell extends CellBase {

private static final Logger LOG = PoiLogManager.getLogger(XSSFCell.class);
private static final String FALSE_AS_STRING = "0";
private static final String TRUE_AS_STRING = "1";
private static final String FALSE = "FALSE";
Expand Down Expand Up @@ -244,7 +247,7 @@ public double getNumericCellValue() {
return 0.0;
}
try {
return Double.parseDouble(v);
return parseDouble(v);
} catch(NumberFormatException e) {
throw typeMismatch(CellType.NUMERIC, CellType.STRING, false);
}
Expand Down Expand Up @@ -330,12 +333,13 @@ private XSSFRichTextString findStringValue() {
} else {
if (_cell.isSetV()) {
try {
int idx = Integer.parseInt(_cell.getV());
int idx = parseInt(_cell.getV());
rt = (XSSFRichTextString)_sharedStringSource.getItemAt(idx);
} catch (Throwable t) {
if (ExceptionUtil.isFatal(t)) {
ExceptionUtil.rethrow(t);
}
LOG.atError().withThrowable(t).log("Failed to parse SST index '{}'", _cell.getV());
rt = new XSSFRichTextString("");
}
} else {
Expand Down Expand Up @@ -1122,12 +1126,12 @@ private boolean convertCellValueToBoolean() {
case BOOLEAN:
return TRUE_AS_STRING.equals(_cell.getV());
case STRING:
int sstIndex = Integer.parseInt(_cell.getV());
int sstIndex = parseInt(_cell.getV());
RichTextString rt = _sharedStringSource.getItemAt(sstIndex);
String text = rt.getString();
return Boolean.parseBoolean(text);
case NUMERIC:
return Double.parseDouble(_cell.getV()) != 0;
return parseDouble(_cell.getV()) != 0;

case ERROR:
// fall-through
Expand All @@ -1149,13 +1153,14 @@ private String convertCellValueToString() {
return TRUE_AS_STRING.equals(_cell.getV()) ? TRUE : FALSE;
case STRING:
try {
int sstIndex = Integer.parseInt(_cell.getV());
int sstIndex = parseInt(_cell.getV());
RichTextString rt = _sharedStringSource.getItemAt(sstIndex);
return rt.getString();
} catch (Throwable t) {
if (ExceptionUtil.isFatal(t)) {
ExceptionUtil.rethrow(t);
}
LOG.atError().withThrowable(t).log("Failed to parse SST index '{}'", _cell.getV());
return "";
}
case NUMERIC:
Expand Down Expand Up @@ -1227,4 +1232,12 @@ public void updateCellReferencesForShifting(String msg){
ctCell.setR(r);
}

private static int parseInt(String value) throws NumberFormatException {
return Integer.parseInt(value.trim());
}

private static double parseDouble(String value) throws NumberFormatException {
return Double.parseDouble(value.trim());
}

}
37 changes: 37 additions & 0 deletions poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ Licensed to the Apache Software Foundation (ASF) under one or more
import org.xml.sax.XMLReader;

import java.io.InputStream;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;

import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -100,4 +102,39 @@ public void cell(final String cellReference, final String formattedValue,
}
}
}

@Test
void testSstStrayWhitespace() throws Exception {
try (OPCPackage xlsxPackage = OPCPackage.open(_ssTests.openResourceAsStream("bug69769.xlsx"))) {
final XSSFReader reader = new XSSFReader(xlsxPackage);
final Iterator<InputStream> iter = reader.getSheetsData();
final Map<String, String> cellValues = new HashMap<>();

try (InputStream stream = iter.next()) {
final XMLReader sheetParser = XMLHelper.getSaxParserFactory().newSAXParser().getXMLReader();

sheetParser.setContentHandler(new XSSFSheetXMLHandler(reader.getStylesTable(),
new ReadOnlySharedStringsTable(xlsxPackage), new SheetContentsHandler() {
@Override
public void startRow(final int rowNum) {
}

@Override
public void endRow(final int rowNum) {
}

@Override
public void cell(final String cellReference, final String formattedValue,
final XSSFComment comment) {
cellValues.put(cellReference, formattedValue);
}
}, false));

assertDoesNotThrow(() -> sheetParser.parse(new InputSource(stream)));

assertEquals(4, cellValues.size());
assertEquals("Mustermann", cellValues.get("B2"));
}
}
}
}
28 changes: 28 additions & 0 deletions poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3910,6 +3910,34 @@ void testBug66827() throws Exception {
}
}

@Test
void testBug69769() throws Exception {
final int expectedCount = 3;
try (XSSFWorkbook wb = openSampleWorkbook("bug69769.xlsx")) {
SharedStringsTable sst = wb.getSharedStringSource();
assertNotNull(sst);
assertEquals(expectedCount, sst.getCount());
for (int i = 0; i < expectedCount; i++) {
assertNotNull(sst.getItemAt(i));
}
XSSFSheet ws = wb.getSheetAt(0);
int nRowCount = ws.getLastRowNum();
DataFormatter df = new DataFormatter();
for (int r = 0; r <= nRowCount; r++) {
XSSFRow row = ws.getRow(r);
if (row != null) {
for (Cell cell : row) {
String cellValue = df.formatCellValue(cell);
assertNotNull(cellValue, "Cell value should not be null");
if (cell.getRowIndex() == 1 && cell.getColumnIndex() == 1) {
assertEquals("Mustermann", cellValue);
}
}
}
}
}
}

private static void readByCommonsCompress(File temp_excel_poi) throws IOException {
/* read by commons-compress*/
try (ZipFile zipFile = ZipFile.builder().setFile(temp_excel_poi).get()) {
Expand Down
Binary file added test-data/spreadsheet/bug69769.xlsx
View file
Open in desktop
Binary file not shown.