Use "clean" LICENSE and NOTICE in published jar artifacts #1292
Conversation
jbonofre
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei and
collado-mike
as code owners
jbonofre
requested review from
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
| -------------------------------------------------------------------------------- | ||
|
|
There was a problem hiding this comment.
I don't mind adding LICENSE file(s) to the non-root projects, but CopiedCodeCheckerPlugin should then also be adopted to check those files as well.
There was a problem hiding this comment.
Just a note: the reason I'm adding LICENSE to the non-root projects is because they are distributed (on Maven). If not distributed, it won't be necessary.
There was a problem hiding this comment.
I registered integration-tests in the check. Please let me know if you want me to use a more global pattern to register all "non-root" project, or if only integration-tests is good enough for now.
There was a problem hiding this comment.
Not fully what I meant.
The CopiedCodeCheckerPlugin needs to look into the special LICENSE file and verify that it contains the necessary mentions.
There was a problem hiding this comment.
Ah ok, you mean having "special" configuration of the checker plugin in the project. Catcha. Let me do that.
There was a problem hiding this comment.
@snazy do you mind to take a new look to be sure I understood what you meant correctly ? Thanks !
There was a problem hiding this comment.
No, I mean updating the functionality in the CopiedCodeCheckerPlugin
There was a problem hiding this comment.
I pass in the configuration of the polaris-test (location of the LICENSE file). I guess you mean to check if project has LICENSE file and fallback to the default one right ?
jbonofre
force-pushed
the
jar-license
branch
3 times, most recently
from
8005359 to
ef6b9fe
Compare
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
...ests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java
Show resolved
Hide resolved
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
In preparation of the next releases (including jar artifacts publication), this PR uses "clean"
LICENSEandNOTICEin published jar artifacts, and "regular" location.