Surface persistence exceptions to the caller more often #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
commented
Apr 9, 2025
| * If this result is failed, this should throw the appropriate exception which corresponds to the | ||
| * result status. See {@link BaseResult#getException} for details. | ||
| */ | ||
| public void maybeThrowException() throws RuntimeException { |
There was a problem hiding this comment.
This helper method is nice to have because you can't throw an exception from a lambda, so you can't do e.g. result.getException().foreach(e -> throw e)
|
Unfortunately some Iceberg tests essentially assert that these methods don't throw exceptions, e.g. To pass these tests, we may want to gate this new behavior behind a flag |
eric-maynard
changed the title
eric-maynard
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
eric-maynard
commented
Apr 9, 2025
|
|
||
| String message = this.extraInformation; | ||
| if (this.extraInformation == null) { | ||
| // TODO this should ideally never be hit but it's hit often. |
There was a problem hiding this comment.
If we merge this, we should file an issue(s) tracking the many callsites where a non-successful result is built with a null message. This might be a good starter task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many
...Catalogmethods likedropPolicyordropGenericTable, we simply returnfalseif there's aBaseResultfrom persistence that doesn't have aSUCCESSerror code. In some cases like inIcebergCatalogwe do a little better, mapping a small subset of failures into exceptions.This PR pushes this mapping down into
BaseResultso that methods which rely onBaseResultto report the success of a persistence call can pass accurate information about the error back to the caller (via the exception mapper in the case of a REST call).In order to support some Iceberg tests that expect methods like
dropTablenot to throw an exception, this functionality is gated behind a feature flagDETAILED_PERSISTENCE_EXCEPTIONS