[Python Client] CI for Python client (Continue PR#1096) #1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
force-pushed
the
honahx_python_client_ci
branch
2 times, most recently
from
b085333 to
6dd362e
Compare
HonahX
changed the title
HonahX
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
ajantha-bhat,
singhpk234 and
pingtimeout
as code owners
HonahX
force-pushed
the
honahx_python_client_ci
branch
from
6dd362e to
a2597b3
Compare
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
flyrain
approved these changes
May 22, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Closed
HonahX
force-pushed
the
honahx_python_client_ci
branch
from
a2597b3 to
08ba290
Compare
|
I think we need to first merge #1347 and then write up the Python client to actually be generated at CI time. Otherwise, we are just testing an outdated version of the client that doesn't conform to the current spec. |
HonahX
force-pushed
the
honahx_python_client_ci
branch
from
08ba290 to
296968c
Compare
|
Rebase to test new client and test for #1347 |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the great work in #1096 since the original author does not have time to continue. It adds CI for python client.
It removes the caching poetry step for now since we do not have
poetry.lock(it is in .gitignore), see relevant discussion in: #1102 (comment), #1096 (comment), we can add that later