-
Notifications
You must be signed in to change notification settings - Fork 332
Site: Rename menu "downloads" to "releases" #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| identifier: "downloads" | ||
| - name: "Releases" | ||
| identifier: "releases" | ||
| url: "/downloads" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to keep it for backward compatibilities, as we've shared the link multiple places. I'm OK to change it to releases as well if people think consistency is more important.
|
@flyrain :
Could you link the discussion? |
Cannot find it :-(. I think @jbonofre was part of the conversation. |
|
Yes I confirm we got a discussion about that. |
|
|
+1 for this rename ! Here is a nice data showing how people coming to download page in our website |
|
Also cannot find a discussion on the mailing list for this. |
|
Yeah, I don't find it either, but I'm sure we discussed about that (during the 0.9.0-incubating prep as far as I remember). As we don't find the thread, maybe worth to point this PR on the mailing list to have a broader information. |
eric-maynard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, especially now that the page contains a lot of details about releases. We should probably consider breaking it up before it just becomes one really long page, but that's out of scope for this PR
Related to this,I've created #3039 to illustrate this and other things related to "many releases". |
We have discussed the renaming of the "downloads" page to "releases". Here is the PR.
How was this patch tested?
Test locally, the new menu "releases" works well. Cannot test versioned doc locally.