Addresses comments from #623 in ActiveRolesProvider

[collado-mike]

Addresses comments from #623

[adutra]

This is making the tests fail, and I think we do have a problem. DefaultActiveRolesProvider expects the principal to have the role PRINCIPAL_ROLE_ALL when all roles are activated:

boolean allRoles = tokenRoles.contains(BasePolarisAuthenticator.PRINCIPAL_ROLE_ALL);

But BasePolarisAuhtenticator creates a principal with an empty roles set in that case. You need to change BasePolarisAuthenticator.getPrincipal():

  if (tokenInfo.getScope() != null) {
      if (tokenInfo.getScope().equals(PRINCIPAL_ROLE_ALL)) {
        activatedPrincipalRoles.add(PRINCIPAL_ROLE_ALL); // this is missing
      } else {
        activatedPrincipalRoles.addAll(...);
      }
    }

[adutra]

@collado-mike if you want to rebase this PR, the two filters were moved/renamed to:

org.apache.polaris.service.auth.PolarisPrincipalAuthenticatorFilter
org.apache.polaris.service.auth.PolarisPrincipalRolesProviderFilter

Both are in polaris-service-common.

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.