-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Pin executor to dispatcher and StreamingEntryReader to cache the string hashing #18566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lifepuzzlefun
approved these changes
Nov 24, 2022
coderzc
approved these changes
Nov 24, 2022
Jason918
approved these changes
Nov 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #18566 +/- ##
============================================
+ Coverage 47.51% 49.60% +2.08%
- Complexity 10520 10803 +283
============================================
Files 698 698
Lines 68079 68084 +5
Branches 7280 7280
============================================
+ Hits 32351 33774 +1423
+ Misses 32151 30654 -1497
- Partials 3577 3656 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0b60bd6
to
77bef42
Compare
77bef42
to
0d4220f
Compare
Merged
4 tasks
labuladong
pushed a commit
to labuladong/pulsar
that referenced
this pull request
Nov 28, 2022
… to cache the string hashing (apache#18566)
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
… to cache the string hashing (apache#18566)
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
… to cache the string hashing (apache#18566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inspired by #18078, Instead of hashing the string each, pin the thread and always use the same, for a given dispatcher instance, also
StreamingEntryReader
.Modifications
Instead of hashing the string each, pin the thread and always use the same, for a given dispatcher instance, also
StreamingEntryReader
.Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: AnonHxy#18