QPIDJMS-295 Add support for content-encoding property #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havret
force-pushed
the
QPIDJMS-295_Add-support-for-content-encoding-property
branch
from
c266c95 to
228f05a
Compare
Contributor
|
Lgtm. |
|
Hi guys. This is and the possibility to read/set content-type also is becoming quite urgent. Any new developments? |
|
@gemmellr I think we need to relax some of the strictness with regards to JMS for this. Is the priority to adhere to JMS standards or AMQP standards? I think a good approach would be to think about downstream projects (for instance camel-amqp). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gemmellr, @michaelandrepearce, @tabish121 could you please take a look? This PR adds access to content-encoding property of the underlying AMQP message. The implementation is based on Advanced Message Queuing Protocol (AMQP) JMS Mapping Version 1.0 Working Draft 9.