RANGER-4993 : Ranger KMS - Missing HSTS Headers for 404 Not found requests port 9494#585
Merged
dhavalshah9131 merged 4 commits intomasterfrom Jul 18, 2025
Merged
RANGER-4993 : Ranger KMS - Missing HSTS Headers for 404 Not found requests port 9494#585dhavalshah9131 merged 4 commits intomasterfrom
dhavalshah9131 merged 4 commits intomasterfrom
Conversation
…uests port 9494
vikaskr22
reviewed
Jun 25, 2025
…uests port 9494
…uests port 9494
vikaskr22
requested changes
Jul 18, 2025
Contributor
vikaskr22
left a comment
There was a problem hiding this comment.
I have added few minor review comments, other things look good to me.
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/HSTSFilter.java
Outdated
Show resolved
Hide resolved
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/HSTSFilter.java
Show resolved
Hide resolved
…uests port 9494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RANGER-4993 : Ranger KMS - Missing HSTS Headers for 404 Not found requests port 9494
HSTS header is missing for 404 Not found requests .
E.G.
curl -ivk -u keyadmin:Admin123 https://:9494/
OR
curl -ivk --negotiate -u : https://:9494
How was this patch tested?
Successfully validated the HSTS header for above API and all the existing APIs such as GET keys, create keys, rollover keys , delete keys.