Skip to content

RANGER-5270 : Audits > Admin tab: Zone name missing in 'Delete Zone Policy' log #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ranger-2.8
Choose a base branch
from
Open

RANGER-5270 : Audits > Admin tab: Zone name missing in 'Delete Zone Policy' log #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import React from "react";
import { Table, Badge, Row, Col } from "react-bootstrap";
import dateFormat from "dateformat";
import { ClassTypes } from "../../../utils/XAEnums";
import { ClassTypes } from "Utils/XAEnums";
import {
isEmpty,
isEqual,
Expand All @@ -34,7 +34,7 @@ import {
includes,
split
} from "lodash";
import { currentTimeZone } from "../../../utils/XAUtils";
import { currentTimeZone } from "Utils/XAUtils";

export const PolicyLogs = ({ data, reportdata }) => {
const {
Expand All @@ -47,6 +47,10 @@ export const PolicyLogs = ({ data, reportdata }) => {
objectId
} = data;

const policyZoneName = reportdata?.find(
(obj) => obj.attributeName === "Zone Name"
);

/* CREATE LOGS VARIABLES */
const createPolicyDetails = reportdata.filter((policy) => {
return (
Expand All @@ -59,7 +63,8 @@ export const PolicyLogs = ({ data, reportdata }) => {
policy.attributeName != "Deny Exceptions" &&
policy.attributeName != "Masked Policy Items" &&
policy.attributeName != "Row level filter Policy Items" &&
policy.attributeName != "Validity Schedules"
policy.attributeName != "Validity Schedules" &&
policy.attributeName != "Zone Name"
);
});

Expand Down Expand Up @@ -1866,6 +1871,11 @@ export const PolicyLogs = ({ data, reportdata }) => {
</div>
<div className="fw-bolder">Policy Name: {objectName}</div>
<div className="fw-bolder">Service Name: {parentObjectName}</div>
{policyZoneName?.newValue ? (
<div className="fw-bolder">
Zone Name: {policyZoneName.newValue}
</div>
) : null}
<div className="fw-bolder">
Created Date: {currentTimeZone(createDate)}
</div>
Expand Down Expand Up @@ -2902,6 +2912,11 @@ export const PolicyLogs = ({ data, reportdata }) => {
</div>
<div className="fw-bolder">Policy Name: {objectName}</div>
<div className="fw-bolder">Service Name: {parentObjectName}</div>
{policyZoneName?.previousValue ? (
<div className="fw-bolder">
Zone Name: {policyZoneName.previousValue}
</div>
) : null}
<div className="fw-bolder">
Deleted Date:{currentTimeZone(createDate)}
</div>
Expand Down Expand Up @@ -3661,6 +3676,11 @@ export const PolicyLogs = ({ data, reportdata }) => {
</div>
<div className="fw-bolder">Policy Name: {objectName}</div>
<div className="fw-bolder">Service Name: {parentObjectName}</div>
{policyZoneName?.previousValue ? (
<div className="fw-bolder">
Zone Name: {policyZoneName.previousValue}
</div>
) : null}
<div className="fw-bolder">
Deleted Date: {currentTimeZone(createDate)}
</div>
Expand Down