RATIS-2421. Gracefully cancel stream after complete in GrpcLogAppender#1363
Open
symious wants to merge 4 commits intoapache:masterfrom
Open
RATIS-2421. Gracefully cancel stream after complete in GrpcLogAppender#1363symious wants to merge 4 commits intoapache:masterfrom
symious wants to merge 4 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When onCompleted() is called, the client waits for the server response to finish the RPC and release the underlying resources.
However, in some cases the server response may never arrive, which leaves the RPC stream open and prevents resources from being released.
This ticket introduces a client-side cancel() after a short grace period following onCompleted(), to ensure the RPC stream is forcefully closed and resources are cleaned up.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2421
How was this patch tested?
Test locally.