[SEDONA-527] Add pre-commit hook check-json; Lint JSON files
#1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Added another hook to our pre-commit framework:
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-json
How was this patch tested?
With the new hook
check-jsonadded I first ran locally:pre-commit run --all-fileswhich showed the JSON files that weren't valid JSON.
Then checked some JSON with JSON Lint online.
https://jsonlint.com/
Then fixed the JSON to be valid JSON.
Did this PR include necessary documentation updates?